Revision: 18234
http://bibdesk.svn.sourceforge.net/bibdesk/?rev=18234&view=rev
Author: hofman
Date: 2011-11-23 11:16:20 +0000 (Wed, 23 Nov 2011)
Log Message:
-----------
use convenience method to create invocation
Modified Paths:
--------------
trunk/bibdesk/BDSKConditionController.m
trunk/bibdesk/BDSKEditor.m
trunk/bibdesk/BDSKFilterController.m
Modified: trunk/bibdesk/BDSKConditionController.m
===================================================================
--- trunk/bibdesk/BDSKConditionController.m 2011-11-23 07:35:10 UTC (rev
18233)
+++ trunk/bibdesk/BDSKConditionController.m 2011-11-23 11:16:20 UTC (rev
18234)
@@ -41,6 +41,7 @@
#import "BibItem.h"
#import "BDSKBooleanValueTransformer.h"
#import "BDSKRatingButton.h"
+#import "NSInvocation_BDSKExtensions.h"
#define BDSKBooleanValueTransformerName @"BDSKBooleanValueTransformer"
#define BDSKTriStateValueTransformerName @"BDSKTriStateValueTransformer"
@@ -369,12 +370,9 @@
- (void)commitEditingWithDelegate:(id)delegate
didCommitSelector:(SEL)didCommitSelector contextInfo:(void *)contextInfo {
if (delegate && didCommitSelector) {
- NSInvocation *invocation = [[NSInvocation
invocationWithMethodSignature:[delegate
methodSignatureForSelector:didCommitSelector]] retain];
- [invocation setTarget:delegate];
- [invocation setSelector:didCommitSelector];
- [invocation setArgument:&self atIndex:2];
+ NSInvocation *invocation = [NSInvocation invocationWithTarget:delegate
selector:didCommitSelector argument:&self];
[invocation setArgument:&contextInfo atIndex:4];
- return [objectController commitEditingWithDelegate:self
didCommitSelector:@selector(editor:didCommit:contextInfo:)
contextInfo:invocation];
+ return [objectController commitEditingWithDelegate:self
didCommitSelector:@selector(editor:didCommit:contextInfo:)
contextInfo:[invocation retain]];
}
return [objectController commitEditingWithDelegate:delegate
didCommitSelector:didCommitSelector contextInfo:contextInfo];
}
Modified: trunk/bibdesk/BDSKEditor.m
===================================================================
--- trunk/bibdesk/BDSKEditor.m 2011-11-23 07:35:10 UTC (rev 18233)
+++ trunk/bibdesk/BDSKEditor.m 2011-11-23 11:16:20 UTC (rev 18234)
@@ -85,6 +85,7 @@
#import "BDSKTemplate.h"
#import "BDSKGroupsArray.h"
#import "NSTableView_BDSKExtensions.h"
+#import "NSInvocation_BDSKExtensions.h"
#define WEAK_NULL NULL
@@ -370,10 +371,7 @@
BOOL didCommit = [self commitEditing];
if (delegate && didCommitSelector) {
// - (void)editor:(id)editor didCommit:(BOOL)didCommit
contextInfo:(void *)contextInfo
- NSInvocation *invocation = [NSInvocation
invocationWithMethodSignature:[delegate
methodSignatureForSelector:didCommitSelector]];
- [invocation setTarget:delegate];
- [invocation setSelector:didCommitSelector];
- [invocation setArgument:&self atIndex:2];
+ NSInvocation *invocation = [NSInvocation invocationWithTarget:delegate
selector:didCommitSelector argument:&self];
[invocation setArgument:&didCommit atIndex:3];
[invocation setArgument:&contextInfo atIndex:4];
[invocation invoke];
Modified: trunk/bibdesk/BDSKFilterController.m
===================================================================
--- trunk/bibdesk/BDSKFilterController.m 2011-11-23 07:35:10 UTC (rev
18233)
+++ trunk/bibdesk/BDSKFilterController.m 2011-11-23 11:16:20 UTC (rev
18234)
@@ -40,6 +40,7 @@
#import "BDSKConditionController.h"
#import "BDSKConditionsView.h"
#import "NSWindowController_BDSKExtensions.h"
+#import "NSInvocation_BDSKExtensions.h"
@implementation BDSKFilterController
@@ -218,10 +219,7 @@
BOOL didCommit = [self commitEditing];
if (delegate && didCommitSelector) {
// - (void)editor:(id)editor didCommit:(BOOL)didCommit
contextInfo:(void *)contextInfo
- NSInvocation *invocation = [NSInvocation
invocationWithMethodSignature:[delegate
methodSignatureForSelector:didCommitSelector]];
- [invocation setTarget:delegate];
- [invocation setSelector:didCommitSelector];
- [invocation setArgument:&self atIndex:2];
+ NSInvocation *invocation = [NSInvocation invocationWithTarget:delegate
selector:didCommitSelector argument:&self];
[invocation setArgument:&didCommit atIndex:3];
[invocation setArgument:&contextInfo atIndex:4];
[invocation invoke];
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
