Sure, no objection to that.
On Mon, Feb 24, 2014 at 5:12 PM, Jeremy Spilman <jer...@taplink.co> wrote: > On Mon, 24 Feb 2014 09:10:26 -0800, Jeff Garzik <jgar...@bitpay.com> wrote: >> >> This PR reduces the size to 40 bytes: >> https://github.com/bitcoin/bitcoin/pull/3737 > > > Just quickly GLANCED at it, but if I understand correctly how the template > matching code works, that will change max size of the <data> to 40 bytes but > does not do anything to enforce most-efficient encoding. > > else if (opcode2 == OP_SMALLDATA) > { > // small pushdata, <= MAX_OP_RETURN_RELAY bytes > if (vch1.size() > MAX_OP_RETURN_RELAY) > break; > } > > This code was a bit hard for me to parse since it's not actually requiring > any data, just disallowing more than a certain number of bytes of data. So a > bare OP_RETURN would be allowed as well, for whatever good that will do. > > If you want to strictly require no PUSHDATA, perhaps you could do: > > else if (opcode2 == OP_SMALLDATA) > { > // small pushdata, <= MAX_OP_RETURN_RELAY bytes > if (opcode1 >= OP_PUSHDATA1 || vch1.size() > MAX_OP_RETURN_RELAY) > break; > } > > Thanks, > Jeremy > -- Jeff Garzik Bitcoin core developer and open source evangelist BitPay, Inc. https://bitpay.com/ ------------------------------------------------------------------------------ Flow-based real-time traffic analytics software. Cisco certified tool. Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer Customize your own dashboards, set traffic alerts and generate reports. Network behavioral analysis & security monitoring. All-in-one tool. http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk _______________________________________________ Bitcoin-development mailing list Bitcoin-development@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bitcoin-development
