Armin K. wrote:
> On 10/08/2012 06:09 PM, Bruce Dubbs wrote:
>> kre...@linuxfromscratch.org wrote:
>>> Author: krejzi
>>> Date: 2012-10-08 00:05:45 -0600 (Mon, 08 Oct 2012)
>>> New Revision: 10721
>>>
>>> Modified:
>>> trunk/BOOK/x/installing/x7app.xml
>>> trunk/BOOK/x/installing/x7font.xml
>>> trunk/BOOK/x/installing/x7lib.xml
>>> trunk/BOOK/x/installing/x7proto.xml
>>> Log:
>>> Minor fixups to Xorg section and AS_ROOT stuff.
>>>
>>> Modified: trunk/BOOK/x/installing/x7app.xml
>>> ===================================================================
>>> --- trunk/BOOK/x/installing/x7app.xml 2012-10-07 23:42:03 UTC (rev
>>> 10720)
>>> +++ trunk/BOOK/x/installing/x7app.xml 2012-10-08 06:05:45 UTC (rev
>>> 10721)
>>> @@ -258,7 +258,7 @@
>>> pushd $packagedir
>>> ./configure $XORG_CONFIG
>>> make
>>> - $AS_ROOT make install
>>> + $AS_ROOT "make install"
>>
>> We have a problem. The above change works for su -c "make install", but
>> fails for sudo "make install" with
>>
>> sudo: make install: command not found
>>
>> The su variation fails without the quotes, so we need to rework this.
>> Personally, I prefer sudo, but can understand that some will want to use
>> su.
>>
>> The only solution I can come up with is to create a bash function
>> something like:
>>
>> as_root()
>> {
>> if [ -x /usr/bin/sudo ]; then
>> sudo $*
>> else
>> su -c \\"$*\\"
>> fi
>> }
>>
>> I can't say I like it, but it works.
>>
>> -- Bruce
>>
>
> Sorry, I didn't have sudo installed. I have just checked it with su -c
> or AS_ROOT not set. Should we remove su -c and just leave sudo and
> installing as root as options?
Well what we have now is wrong and what we had before is also wrong.
The above is right, but may not be elegant. It is, however, somewhat
educational.
It could be collapsed to two physical lines:
as_root() { if [ -x /usr/bin/sudo ]; then sudo $*
else su -c \\"$*\\"; fi }
We only need to change the entity and then the $AS_ROOT to as_root in
the 4 places needed.
-- Bruce
--
http://linuxfromscratch.org/mailman/listinfo/blfs-dev
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page
