LGTM2

On 3/26/24 10:50 PM, Domenic Denicola wrote:
LGTM1, this is a very small change that IMO does not require any signals or TAG review. It's just bringing this event in line with all other events on the platform.

(It would be cool if there were some automated way of preventing this kind of omission in the future.)

On Wednesday, March 27, 2024 at 9:49:16 AM UTC+9 David Awogbemila wrote:


            Contact emails

    awogbem...@google.com


            Explainer

    None


            Specification

    https://drafts.csswg.org/cssom-view/#the-visualviewport-interface
    <https://drafts.csswg.org/cssom-view/#the-visualviewport-interface>


            Summary

    Scrollend is a JavaScript event that fires to signal that a
    scrolling operation has come to an end. Similar to the Element
    interface[1], the visualViewport interface[2] includes an
    onscrollend event handler that should be invoked when a scrolling
    operation on the visualViewport has ended. Chromium already
    supports adding a scrollend event listener via
    `visualViewport.addEventListener("scrollend")`. This just makes it
    possible to also add an event listener using
    `visualViewport.onscrollend`.
    
[1]https://html.spec.whatwg.org/multipage/webappapis.html#handler-onscrollend
    <https://html.spec.whatwg.org/multipage/webappapis.html#handler-onscrollend>
    [2]https://drafts.csswg.org/cssom-view/#dom-visualviewport-onscrollend
    <https://drafts.csswg.org/cssom-view/#dom-visualviewport-onscrollend>.



            Blink component

    Blink>Scroll
    
<https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EScroll>


            TAG review

    None


            TAG review status

    Not applicable


            Risks



            Interoperability and Compatibility

    None



    /Gecko/: No signal

    /WebKit/: No signal

    /Web developers/: No signals

    /Other signals/:


            WebView application risks

    Does this intent deprecate or change behavior of existing APIs,
    such that it has potentially high risk for Android WebView-based
    applications?

    None



            Debuggability

    This makes it possible to add breakpoints to event handlers added
    by `visualViewport.onscrollend` similar to
    `visualViewport.onscroll` or onscrollend for any other element.



            Will this feature be supported on all six Blink platforms
            (Windows, Mac, Linux, ChromeOS, Android, and Android WebView)?

    Yes


            Is this feature fully tested by web-platform-tests
            
<https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>?

    Yes

    
https://wpt.fyi/results/dom/events/scrolling/scrollend-event-fires-on-visual-viewport.html?label=experimental&label=master&aligned
    
<https://wpt.fyi/results/dom/events/scrolling/scrollend-event-fires-on-visual-viewport.html?label=experimental&label=master&aligned>



            Flag name on chrome://flags

    None


            Finch feature name

    ScrollEndEvents


            Requires code in //chrome?

    False


            Tracking bug

    https://crbug.com/325307785


            Estimated milestones

    Shipping on desktop         125

    Shipping on Android         125

    Shipping on WebView         125



            Anticipated spec changes

    Open questions about a feature may be a source of future web
    compat or interop issues. Please list open issues (e.g. links to
    known github issues in the project for the feature specification)
    whose resolution may introduce web compat/interop risk (e.g.,
    changing to naming or structure of the API in a
    non-backward-compatible way).

    None


            Link to entry on the Chrome Platform Status

    https://chromestatus.com/feature/5774579609108480?gate=4770235262697472
    <https://chromestatus.com/feature/5774579609108480?gate=4770235262697472>

    This intent message was generated by Chrome Platform Status
    <https://chromestatus.com/>.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/db5674cc-3c3c-4092-bed7-9cf64c2fc59bn%40chromium.org <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/db5674cc-3c3c-4092-bed7-9cf64c2fc59bn%40chromium.org?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/2dd028f6-c935-48ff-aca0-079c0a39b027%40chromium.org.

Reply via email to