LGTM1

On 4/4/24 2:29 PM, 'Thomas Guilbert' via blink-dev wrote:
The last launch gate approval came in today.

Thanks!

On Wed, Apr 3, 2024 at 11:49 AM Thomas Guilbert <tguilb...@google.com> wrote:

    I agree that this would have been a viable solution, and this was
    considered and discussed with the spec editors too [1]. These Opus
    flags were originally supposed to be contentHint, but ultimately
    it would have only ever been useful for Opus, so it was decided to
    keep it in the Opus config.

    [1] :
    https://github.com/w3c/webcodecs/pull/759#issuecomment-1928349508

    On Wed, Apr 3, 2024 at 9:10 AM Daniel Bratell
    <bratel...@gmail.com> wrote:

        This may be a bit of a tangent, but we had a discussion about
        AV1-only encoder configuration a while back[1][2]. In the end
        they elected to have a top level dictionary where some
        encoding configuration ended up. I wonder if there is anything
        to learn from that process and their choices or if you
        consider that orthogonal to this.

        /Daniel

        [1] AV1:
        
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADxkKiLH6ViLccGxHZzbCG_ChtSxiG59XoeYMPRqeW1Wk410rg%40mail.gmail.com

        [2] ContentHint:
        
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAFUtAY9K9_YmJRFn%3DQBKb0GsETsSFex0DPprMRRpWUWgcvAtbA%40mail.gmail.com


        On 2024-03-28 08:43, Yoav Weiss (@Shopify) wrote:
        Thanks!

        On Wed, Mar 27, 2024 at 10:41 PM Thomas Guilbert
        <tguilb...@chromium.org> wrote:

            I've flipped all the reviews and will update this thread
            when they are all completed.

            Thanks!

            On Wed, Mar 27, 2024 at 8:25 AM Yoav Weiss (@Shopify)
            <yoavwe...@chromium.org> wrote:

                Hey! Can you flip on the various reviews (privacy,
                enterprise, etc) in the chromestatus entry?

                On Tuesday, March 26, 2024 at 11:29:53 PM UTC+1
                Thomas Guilbert wrote:


                            Contact emails


                            tguilb...@chromium.org


                            Explainer


                            None


                            Specification


                            
https://w3c.github.io/webcodecs/opus_codec_registration.html#dom-opusencoderconfig-signal


                            Summary


                            `OpusEncoderConfig.signal` and
                            `OpusEncoderConfig.application` were
                            recently added to the WebCodecs spec [1].
                            Both parameters are mapped directly to
                            implementation specific encoder knobs.
                            These allow web authors to provide hints
                            as to what type of data is being encoded,
                            and in which context the data is being
                            used. `signal` can be one of {"auto",
                            "music", "voice"}. It configures the
                            encoder for the best performance in
                            encoding the specified type of data.
                            `application` can be one of {"voip",
                            "audio", "lowdelay"}. It configures the
                            encoder to favor speech intelligibility,
                            faithful reproduction of the original
                            input, or minimal latency. [1] :
                            https://github.com/w3c/webcodecs/pull/777



                            Blink component


                            Blink>Media>WebCodecs
                            
<https://bugs.chromium.org/p/chromium/issues/list?q=component:Blink%3EMedia%3EWebCodecs>


                            TAG review


                            None


        Why not?




                            TAG review status


                            Not applicable


                            Risks




                            Interoperability and Compatibility


                            None



                            /Gecko/: Positive
                            (https://github.com/w3c/webcodecs/pull/777)
                            Spec change approved by Mozilla
                            representative. For an almost identical
                            feature, Mozilla said the "request for
                            standards position" was not warranted, as
                            they were active spec participants:
                            
https://github.com/mozilla/standards-positions/issues/837#issuecomment-1614666364

                            /WebKit/: No signal. Review from WebKit
                            was requested on the spec change.


        Can you ask for official positions? https://bit.ly/blink-signals



                            /Web developers/: No signals

                            /Other signals/:


                            WebView application risks


                            Does this intent deprecate or change
                            behavior of existing APIs, such that it
                            has potentially high risk for Android
                            WebView-based applications?

                            None



                            Debuggability




                            Will this feature be supported on all six
                            Blink platforms (Windows, Mac, Linux,
                            ChromeOS, Android, and Android WebView)?


                            Yes


                            Is this feature fully tested by
                            web-platform-tests
                            
<https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md>?


                            Yes

                            Existing WPTs will be modified to cover
                            this feature:
                            
https://wpt.fyi/results/webcodecs/audio-encoder-config.https.any.html



                            Flag name on chrome://flags


                            None


                            Finch feature name


                            None


                            Non-finch justification


                            Simple parameter changes.



                            Requires code in //chrome?


                            False


                            Estimated milestones


                            Shipping on desktop         125

                            Shipping on Android         125



                            Anticipated spec changes


                            Open questions about a feature may be a
                            source of future web compat or interop
                            issues. Please list open issues (e.g.
                            links to known github issues in the
                            project for the feature specification)
                            whose resolution may introduce web
                            compat/interop risk (e.g., changing to
                            naming or structure of the API in a
                            non-backward-compatible way).

                            None


                            Link to entry on the Chrome Platform Status


                            https://chromestatus.com/feature/5165257615212544

                            This intent message was generated by
                            Chrome Platform Status
                            <https://chromestatus.com/> and edited by
                            hand afterwards.

-- You received this message because you are subscribed to the
        Google Groups "blink-dev" group.
        To unsubscribe from this group and stop receiving emails from
        it, send an email to blink-dev+unsubscr...@chromium.org.
        To view this discussion on the web visit
        
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohSKLbhC60_zVAt46RVhhSGxMfRcnSkdqfcevytScrXuTmg%40mail.gmail.com
        
<https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOmohSKLbhC60_zVAt46RVhhSGxMfRcnSkdqfcevytScrXuTmg%40mail.gmail.com?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABrVPoZamSAMNegqkOKVa8J2w4pBd-1T9eMNaUze_jtQ8p5LOA%40mail.gmail.com <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CABrVPoZamSAMNegqkOKVa8J2w4pBd-1T9eMNaUze_jtQ8p5LOA%40mail.gmail.com?utm_medium=email&utm_source=footer>.

--
You received this message because you are subscribed to the Google Groups 
"blink-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to blink-dev+unsubscr...@chromium.org.
To view this discussion on the web visit 
https://groups.google.com/a/chromium.org/d/msgid/blink-dev/64cb1447-c3e6-4489-9c55-6cbedc68a538%40chromium.org.

Reply via email to