LGTM3 On Tue, Aug 26, 2025 at 9:01 AM 'Guido Urdaneta' via blink-dev < blink-dev@chromium.org> wrote:
> On Mon, Aug 25, 2025 at 8:18 PM Alex Russell <slightly...@chromium.org> > wrote: > >> LGTM2. The extension to a property bag carries some compat risk, but >> presumably that is reduced with the property bag casting to `true`, and all >> of its values being some version of truthiness? >> >> > That's correct. > > > >> Best, >> >> Alex >> >> On Monday, August 25, 2025 at 1:55:20 AM UTC-7 Yoav Weiss wrote: >> >>> LGTM1 >>> >>> On Fri, Aug 22, 2025 at 11:18 AM Chromestatus < >>> ad...@cr-status.appspotmail.com> wrote: >>> >>>> Contact emails o...@google.com, gui...@google.com >>>> >>>> Explainer >>>> https://github.com/guidou/mediacapture-main/blob/master/explainer-echo-cancellation-mode.md >>>> >>>> Specification >>>> https://www.w3.org/TR/mediacapture-streams/#dom-echocancellationmodeenum >>>> >>>> Summary >>>> >>>> Extends echoCancellation behavior of MediaTrackConstraints dictionary - >>>> former true/false - by values "all" and "remote-only". Allows the clients >>>> to modify echo cancellation behavior applied to audio tracks received from >>>> microphones, controlling how much of the user system playout (all, or only >>>> audio received from PeerConnections) is removed from the microphone signal. >>>> >>>> >>>> Blink component Blink>WebRTC>Audio >>>> <https://issues.chromium.org/issues?q=customfield1222907:%22Blink%3EWebRTC%3EAudio%22> >>>> >>>> TAG review https://github.com/w3ctag/design-reviews/issues/1107 >>>> >>>> TAG review status Issues addressed >>>> >>>> Risks >>>> >>>> >>>> Interoperability and Compatibility >>>> >>>> None >>>> >>>> >>>> *Gecko*: No signal ( >>>> https://github.com/mozilla/standards-positions/issues/1241) Spec >>>> change approved by Mozilla's representative in the WG: >>>> https://github.com/w3c/mediacapture-main/pull/1044#pullrequestreview-2861443312 >>>> >>>> *WebKit*: No signal ( >>>> https://github.com/WebKit/standards-positions/issues/507) Spec change >>>> approved by Apple's representative in the WG: >>>> https://github.com/w3c/mediacapture-main/pull/1044#pullrequestreview-2861451798 >>>> >>>> *Web developers*: No signals >>>> >>>> *Other signals*: >>>> >>>> WebView application risks >>>> >>>> Does this intent deprecate or change behavior of existing APIs, such >>>> that it has potentially high risk for Android WebView-based applications? >>>> >>>> None >>>> >>>> >>>> Debuggability >>>> >>>> None >>>> >>>> >>>> Will this feature be supported on all six Blink platforms (Windows, >>>> Mac, Linux, ChromeOS, Android, and Android WebView)? Yes >>>> >>>> Is this feature fully tested by web-platform-tests >>>> <https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md> >>>> ? No >>>> >>>> Flag name on about://flags None >>>> >>>> Finch feature name GetUserMediaEchoCancellationModes >>>> >>>> Rollout plan Will ship enabled for all users >>>> >>>> Requires code in //chrome? False >>>> >>>> Launch bug https://launch.corp.google.com/launch/4403929 >>>> >>>> Availability expectation Feature is available only in Chromium >>>> browsers for the foreseeable future. >>>> >>>> Adoption expectation Feature is used by specific partner(s) to provide >>>> functionality within 12 months of launch in Chrome. >>>> >>>> Estimated milestones >>>> Shipping on desktop 141 >>>> Shipping on Android 141 >>>> Shipping on WebView 141 >>>> Shipping on iOS 141 >>>> >>>> Anticipated spec changes >>>> >>>> Open questions about a feature may be a source of future web compat or >>>> interop issues. Please list open issues (e.g. links to known github issues >>>> in the project for the feature specification) whose resolution may >>>> introduce web compat/interop risk (e.g., changing to naming or structure of >>>> the API in a non-backward-compatible way). >>>> None >>>> >>>> Link to entry on the Chrome Platform Status >>>> https://chromestatus.com/feature/5585747985563648?gate=4921109098790912 >>>> >>>> This intent message was generated by Chrome Platform Status >>>> <https://chromestatus.com>. >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "blink-dev" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to blink-dev+unsubscr...@chromium.org. >>>> To view this discussion visit >>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/68a835ec.050a0220.8fac8.5db4.GAE%40google.com >>>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/68a835ec.050a0220.8fac8.5db4.GAE%40google.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- > You received this message because you are subscribed to the Google Groups > "blink-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to blink-dev+unsubscr...@chromium.org. > To view this discussion visit > https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CA%2BBuZxZWytBEZkuOj5u%3DOGHfOvjHWfzAxDPDO39Ke4gh5CT4bg%40mail.gmail.com > <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CA%2BBuZxZWytBEZkuOj5u%3DOGHfOvjHWfzAxDPDO39Ke4gh5CT4bg%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "blink-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-dev+unsubscr...@chromium.org. To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAOMQ%2Bw_986oeyR%2BYFM6qun6Y4v38PmxGojvRceEnkt%3DhSas9ag%40mail.gmail.com.
