On Thursday 16 September 2010, Eric Blake wrote: > On 09/15/2010 09:48 AM, Stefano Lattarini wrote: > >>> <http://lists.freedesktop.org/archives/pkg-config/2010-Augus > >>> t/0 00631.html> > >>> > >>> (which has since been fixed in the pkg-config git repo, BTW). > >>> There should be a reference also on the autoconf list > >>> somewhere... > > Yes, it looks like this is the same topic: > http://thread.gmane.org/gmane.comp.sysutils.autoconf.general/13133/ > focus=13153 > > > You might want to look at commit > > 2b86e9b4664fd43622e2cd5ab47713a818758970 > > > in the pkg-config git repository: > I needed to see more context. Is there a gitweb URL for this > commit? Not that I know of, sorry. > http://pkg-config.freedesktop.org/wiki/ wasn't as helpful; Yep. > it only listed how to clone the repository instead of browsing it > on the web. That's what I did in the end: I cloned the repo and used "git log".
> At any rate, after cloning the file, and looking at > > $ git show 2b86e9b:pkg.m4 > > I see that pkg-config was roughly doing: > > > AC_MSG_ERROR([... > _PKG_TEXT])dnl > > and expecting _PKG_TEXT to be recognized as a macro name. > AC_MSG_ERROR is a synonym for AS_ERROR, which indeed changed in > 2.66, in commit > http://git.savannah.gnu.org/cgit/autoconf.git/commit/?id=cffdc394 > > The key part to note is this chunk: > > -[m4_ifvaln([$2], [{ AS_SET_STATUS([$2])])]dnl > -[as_fn_error "_AS_QUOTE([$1])"m4_ifval(AS_MESSAGE_LOG_FD, > - [ "$LINENO" AS_MESSAGE_LOG_FD])[]m4_ifval([$2], [; }])]) > +[as_fn_error m4_default([$2], [$?]) > "_AS_QUOTE([$1])"m4_ifval(AS_MESSAGE_LOG_FD, > + [ "$LINENO" AS_MESSAGE_LOG_FD])]) > > The macro used to end with '}', but now ends with > AS_MESSAGE_LOG_FD. So it is indeed an autoconf regression. > Adding the [] should fix it; I'm working on patching the testsuite > to catch this first, though. > > Thanks for persisting on this one! Thanks for explaining and fixing it ;-) Regards, Stefano