Hi Paul, Noah, * Paul Eggert wrote on Thu, Sep 15, 2005 at 04:56:04PM CEST: > Ralf Wildenhues <[EMAIL PROTECTED]> writes: > > > I learned about this issue while actually trying to make use of a module > > with one of the unguarded files; I did not use AC_CONFIG_HEADERS. > > Ok, sorry, I didn't know people still did that. In that case, let's > keep the #if. > > > Surely there are also reasons for `#if'. > > Yes: basically it's easier to read. But given your list of problems > we might as well stick with #ifdef. It's no big deal either way.
OK. Here's the second patch updated, then. (The first and third from my other post are now either agreed upon, I guess :) Cheers, Ralf * __fpending.h, argp-fmtstream.h, dirfd.h, getdate.h, human.h, inttostr.h: Removed inclusion of config.h from header files. * inttostr.c: Adjusted in-tree users. * timespec.h: Remove superfluous warning to include config.h.
* __fpending.h, argp-fmtstream.h, dirfd.h, getdate.h, human.h, inttostr.h: Removed inclusion of config.h from header files. * inttostr.c: Adjusted in-tree users. * timespec.h: Remove superfluous warning to include config.h. Index: lib/__fpending.h =================================================================== RCS file: /cvsroot/gnulib/gnulib/lib/__fpending.h,v retrieving revision 1.4 diff -u -r1.4 __fpending.h --- lib/__fpending.h 4 Jun 2003 19:22:29 -0000 1.4 +++ lib/__fpending.h 16 Sep 2005 13:59:35 -0000 @@ -1,7 +1,3 @@ -#if HAVE_CONFIG_H -# include <config.h> -#endif - #include <stddef.h> #include <stdio.h> Index: lib/argp-fmtstream.h =================================================================== RCS file: /cvsroot/gnulib/gnulib/lib/argp-fmtstream.h,v retrieving revision 1.4 diff -u -r1.4 argp-fmtstream.h --- lib/argp-fmtstream.h 14 May 2005 06:03:57 -0000 1.4 +++ lib/argp-fmtstream.h 16 Sep 2005 13:59:35 -0000 @@ -25,10 +25,6 @@ #ifndef _ARGP_FMTSTREAM_H #define _ARGP_FMTSTREAM_H -#ifdef HAVE_CONFIG_H -#include <config.h> -#endif - #include <stdio.h> #include <string.h> #include <unistd.h> Index: lib/dirfd.h =================================================================== RCS file: /cvsroot/gnulib/gnulib/lib/dirfd.h,v retrieving revision 1.5 diff -u -r1.5 dirfd.h --- lib/dirfd.h 14 May 2005 06:03:58 -0000 1.5 +++ lib/dirfd.h 16 Sep 2005 13:59:35 -0000 @@ -17,10 +17,6 @@ Written by Jim Meyering. */ -#if HAVE_CONFIG_H -# include <config.h> -#endif - #include <sys/types.h> #if HAVE_DIRENT_H Index: lib/getdate.h =================================================================== RCS file: /cvsroot/gnulib/gnulib/lib/getdate.h,v retrieving revision 1.12 diff -u -r1.12 getdate.h --- lib/getdate.h 14 May 2005 06:03:58 -0000 1.12 +++ lib/getdate.h 16 Sep 2005 13:59:35 -0000 @@ -16,10 +16,6 @@ along with this program; if not, write to the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ -#if HAVE_CONFIG_H -# include <config.h> -#endif - #include <stdbool.h> #include "timespec.h" Index: lib/human.h =================================================================== RCS file: /cvsroot/gnulib/gnulib/lib/human.h,v retrieving revision 1.12 diff -u -r1.12 human.h --- lib/human.h 14 May 2005 06:03:58 -0000 1.12 +++ lib/human.h 16 Sep 2005 13:59:35 -0000 @@ -22,10 +22,6 @@ #ifndef HUMAN_H_ # define HUMAN_H_ 1 -# if HAVE_CONFIG_H -# include <config.h> -# endif - # include <limits.h> # include <stdbool.h> Index: lib/inttostr.c =================================================================== RCS file: /cvsroot/gnulib/gnulib/lib/inttostr.c,v retrieving revision 1.2 diff -u -r1.2 inttostr.c --- lib/inttostr.c 14 May 2005 06:03:58 -0000 1.2 +++ lib/inttostr.c 16 Sep 2005 13:59:35 -0000 @@ -18,6 +18,9 @@ /* Written by Paul Eggert */ +#ifdef HAVE_CONFIG_H +# include <config.h> +#endif #include "inttostr.h" /* Convert I to a printable string in BUF, which must be at least Index: lib/inttostr.h =================================================================== RCS file: /cvsroot/gnulib/gnulib/lib/inttostr.h,v retrieving revision 1.4 diff -u -r1.4 inttostr.h --- lib/inttostr.h 14 May 2005 06:03:58 -0000 1.4 +++ lib/inttostr.h 16 Sep 2005 13:59:35 -0000 @@ -18,10 +18,6 @@ /* Written by Paul Eggert */ -#if HAVE_CONFIG_H -# include <config.h> -#endif - #if HAVE_INTTYPES_H # include <inttypes.h> #endif Index: lib/timespec.h =================================================================== RCS file: /cvsroot/gnulib/gnulib/lib/timespec.h,v retrieving revision 1.6 diff -u -r1.6 timespec.h --- lib/timespec.h 16 Sep 2005 06:52:14 -0000 1.6 +++ lib/timespec.h 16 Sep 2005 13:59:35 -0000 @@ -19,8 +19,6 @@ #if ! defined TIMESPEC_H # define TIMESPEC_H -/* You must include config.h before including this file. */ - # include <sys/types.h> # if TIME_WITH_SYS_TIME # include <sys/time.h>
_______________________________________________ bug-gnulib mailing list bug-gnulib@gnu.org http://lists.gnu.org/mailman/listinfo/bug-gnulib