Simon Josefsson <si...@josefsson.org> wrote: > Hi Jim. The patch breaks openmp on debian etch. The patch below fixes > it, but maybe the remaining quoting also cause problems if you use > fortran (I don't know how to test that).
Hi Simon, Nice catch. > gnu...@mejsel:~$ gnulib-tool --test --with-tests openmp ... > executing aclocal -I glm4 > configure.ac:101: error: _AC_LANG_OPENMP: unknown language: _AC_LANG ... > gnu...@mejsel:~/gnulib$ autoconf --version ... > diff --git a/m4/openmp.m4 b/m4/openmp.m4 ... > AC_DEFUN([_AC_LANG_OPENMP], > -[_AC_LANG_DISPATCH([$0], [_AC_LANG], [...@])]) > +[_AC_LANG_DISPATCH([$0], _AC_LANG, [...@])]) This one makes sense. It fails on etch because it has autoconf < 2.62, so the otherwise if'd out definition in openmp.m4 is used. The tests passed for me because I used 2.63+, and then it uses the definition of AC_OPENMP from autoconf. > # _AC_LANG_OPENMP(C) > # ------------------ > -m4_define([_AC_LANG_OPENMP([C])], > +m4_define([_AC_LANG_OPENMP(C)], Is this change really necessary? > [ > #ifndef _OPENMP > choke me > @@ -30,7 +30,7 @@ int main () { return omp_get_num_threads (); } > > # _AC_LANG_OPENMP(C++) > # -------------------- > -m4_copy([_AC_LANG_OPENMP([C])], [_AC_LANG_OPENMP([C++])]) > +m4_copy([_AC_LANG_OPENMP(C)], [_AC_LANG_OPENMP([C++])]) And this? If "C" must not be quoted, then shouldn't the quotes around "C++" be dropped, too?