Re: Remote buffer overflow in Webalizer

[Lars Hecking]

Franck Coppola writes:
> Here is a patch to fix the vulnerability (tested against 
> webalizer-2.01-06). 
>     Franck 
 
 I assume the fact that the patch was in some mangled, binary-ish format
 was the reason why it slipped through to the list. It is quite obviously
 wrong (see man strncpy()).

|--- dns_resolv.c        Tue Apr 16 00:53:19 2002
|***************
|*** 445,449 ****
|                                     size,strlen(res_ent->h_name));
|  
|!                         strcpy(child_buf, res_ent->h_name);
|                          size = strlen(child_buf);
|                       }
|--- 445,449 ----
|                                     size,strlen(res_ent->h_name));
|  
|!                         strncpy(child_buf, res_ent->h_name, MAXHOST);
|                          size = strlen(child_buf);
|                       }