On Fri, 5 Apr 2024 10:45:24 GMT, Robbin Ehn <r...@openjdk.org> wrote:
>> Hi, please consider. >> >> [8327045](https://bugs.openjdk.org/browse/JDK-8327045) hide these symbols. >> Tested with gcc and clang, and llvm and binutils backend. >> >> I didn't find any use of the "DLL_ENTRY", so I removed it. >> >> Thanks, Robbin > > Robbin Ehn has updated the pull request incrementally with one additional > commit since the last revision: > > Use JNIEXPORT Yea, I know, but if hsdis is not an external library I considered it part of hotspot as it is the only use, hence I want two reviews. :) ------------- PR Comment: https://git.openjdk.org/jdk/pull/18400#issuecomment-2044575768
