On Tue, 16 Apr 2024 09:15:19 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> That was kind of where the discussion started, and which Kim did not like. >> If I read him correctly, his suggestion was instead to place: >> >> #if defined(_AIX) >> #include <alloca.h> >> #endif >> >> in the files where `alloca` is needed on AIX. > > (If some of these files happen to be files which are not compiled on Windows, > I assume it will not hurt to drop the ifdef guard, but then again, it can > certainly be kept as well for consistency.) Windows does use this file, in the unofficial Windows/gcc Port. That said, I am fairly sure the Windows distribution of gcc does recognise alloca.h. It would be a little strange to unconditionally include this if only AIX needs it, though ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18536#discussion_r1567076923
