On Wed, 1 May 2024 14:46:14 GMT, SendaoYan <s...@openjdk.org> wrote:

>> Hi,
>> 
>> In doc/testing.md file, it says:
>> 
>> As an example, :tier1 will expand to 
>> jtreg:$(TOPDIR)/test/hotspot/jtreg:tier1 jtreg:$(TOPDIR)/test/jdk:tier1 
>> jtreg:$(TOPDIR)/test/langtools:tier1 jtreg:$(TOPDIR)/test/nashorn:tier1 
>> jtreg:$(TOPDIR)/test/jaxp:tier1.
>> 
>> The actual situation is :tier1 doesn't contains test/nashorn:tier1, and the 
>> document missed test/lib-test:tier1
>> 
>> $ make -n test-tier1 &> test-tier1.log
>> $ grep "Running test " test-tier1.log
>> Running test 'jtreg:test/hotspot/jtreg:tier1'
>> Running test 'jtreg:test/jdk:tier1'
>> Running test 'jtreg:test/langtools:tier1'
>> Running test 'jtreg:test/jaxp:tier1'
>> Running test 'jtreg:test/lib-test:tier1'
>> 
>> Only change the document, no risk.
>
> SendaoYan has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   deliberately making it shorter and ading ... show that this is not am 
> exhaustive list

LGTM. Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19002#pullrequestreview-2034554883

Reply via email to