On Thu, 2 May 2024 08:23:38 GMT, Vladimir Petko <vpe...@openjdk.org> wrote:
> Hi, > > The `.type _SafeFetch32_impl,@function` symbol declaration contains a > spurious underscore causing an undefined symbol in libjvm.so. > > I am not sure about change in default flags. I have removed the flag that > allows linking with undefined symbols > because having the flag on might cause bugs like this one or > https://bugs.openjdk.org/browse/JDK-8329983 as the build succeeds even if > some symbols are not defined. > Openjdk builds successfully without it on amd64, i386, armhf, arm64, s390, > ppc64el and riscv64 with this change[1]. riscv64 build was done locally > inside vm: > > Finished building target 'images' in configuration > 'linux-riscv64-server-release' > ubuntu@ubuntu:~/jdk$ > > Unfortunately I do not know why it was introduced, so I might be missing > something. > I am happy to drop it from this one or move it to a separate issue/pr. > > [1] > https://launchpad.net/~vpa1977/+archive/ubuntu/october-21/+sourcepub/16076564/+listing-archive-extra This pull request has now been integrated. Changeset: 2d622152 Author: Vladimir Petko <vpe...@openjdk.org> Committer: Magnus Ihse Bursie <i...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/2d622152b07bba0aba8fd5b1e24293e28d6e69f5 Stats: 2 lines in 2 files changed: 0 ins; 1 del; 1 mod 8331541: [i386] linking with libjvm.so fails after JDK-8283326 Reviewed-by: djelinski, ihse ------------- PR: https://git.openjdk.org/jdk/pull/19048
