On Wed, 24 Apr 2024 09:15:21 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

>> WIP
>> 
>> This changeset contains hsdis for Windows/gcc Port. It supports both the 
>> binutils and capstone backends, though the LLVM backend is left out due to 
>> compatibility issues encountered during the build. Currently, which gcc 
>> distributions are supported is still to be clarified, as several, ranging 
>> from Cygwin, to MinGW64, to the gcc subsystems from MSYS2. For this reason, 
>> the build system hack in place at the moment to compile the binutils backend 
>> on Windows is still left in place, for now.
>
> Please mark the PR as draft it is not intended for review.

Also @magicus, what is the typical path passed to --with-binutils like on 
Windows? Something like 
--with-binutils=/c/Users/vertig0/Downloads/binutils-2.42 doesn't work 
correctly, since the include path to dis-asm.h would then become
`#include "/c/Users/vertig0/Downloads/binutils-2.42/include/dis-asm.h"`
Which causes a configure check to fail on the compile stage since gcc cannot 
recognise the MINGW-esque /c/ as a drive, and then causes configure to 
erroneously report binutils as using the Old API when it's in fact using the 
New API. --with-binutils=C:/Users/vertig0/Downloads/binutils-2.42 on the other 
hand works as expected. Should there be a fixup for the path there so gcc can 
recognise it properly?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18915#issuecomment-2102146604

Reply via email to