> My feeling about hashed spool directories is that this functionality is
> site-specific, with no obvious single definition of how it is to be
> implemented that applies in all instances.  Consequently, I consider it to
> be something that should always be of the form of a third-party patch
> rather than an official part of c-client.  I do encourage you to continue
> distributing this patch since it's likely to be useful for some people

Thank you for your feedback.

Procmail has included support for hashed spool directories since 3.13,
so I don't think the feature is that site specific. (see
procmail/src/authenticate.c "#define MAILSPOOLHASH 0")

> For what it's worth, I suggest the following alternative implementation of
> your patch, which avoids needless rescans of the string:
> 
>    int i;
>    char *u,*s;
>    strcpy (tmp,MAILSPOOL);
>    for (i = 0, u = myusername (), s = tmp + strlen (tmp);
>         (*s++ = '/') && (i < spool_hash_depth) && u[i];
>         *s++ = u[i++]);
>    strcpy (s,u);

See my new patch against imap-2004rc6.  Further comments are welcome.


Cheers.

Reply via email to