Hi Joel, Hi Patrick, I changed the code regarding your comments and rebased it on the latest tip of the ccache repo. Please take again a look at it.
Kind regards, Michael Am 14.10.2013 um 20:59 schrieb Joel Rosdahl <j...@rosdahl.net>: > Hi Michael, > > > what is the state of CCache on Windows? > > Don't know as I've never tried it myself on Windows, but Ramiro Polla and > Patrick von Reth have been contributing win32 code. Your patch looks > reasonable if it's not a bad idea to normalize drive letter case and slashes > in paths in Windows. Any thoughts from Ramiro or Patrick? > > A couple of things, though: > > * The loops where you change backslashes to forward slashes evaluate > strlen(p) for each character in the string. That's not very efficient - > calculate the size once outside the loop instead. > * Setting the character after the string to 0x0 is redundant since the string > is NUL-terminated already. > > -- Joel > > On 11 October 2013 21:16, Michael Augustin <maugus...@gmx.net> wrote: > Hi CCache Developer, > > what is the state of CCache on Windows? Is it working together with cmake and > Unix Makefiles on Windows, without msys, but with cygwin? > > I ask because I've created a patch some time ago and send it to this list. It > make sure that all path are converted to forward slash paths just before > comparing against already hashed data. It also make sure that absolute > windows paths starting with driveletters are recognized as absolute paths - > e.g. for replacing that part with CCACHE_BASEDIR value. > > I've added my patch here again, but it's possible that it doesn't apply > cleanly since I've posted it already at 20.06.2013. > > > > > Kind regards, > Michael > > > Am 16.09.2013 um 22:55 schrieb Michael Augustin <maugus...@gmx.net>: > > > Hi Patrick, > > > > I used slashes because of CMake. It doesn't like backslashes in path names. > > > > Windows is able to deal with both, but since software development should > > work cross platform, it's very useful to stick with one format. > > CMake/MinGW/Cygwin - all useful tools on Windows work better with slashes > > in pathnames. > > > > Kind regards, > > Michael > > _______________________________________________ > > ccache mailing list > > ccache@lists.samba.org > > https://lists.samba.org/mailman/listinfo/ccache > > > _______________________________________________ > ccache mailing list > ccache@lists.samba.org > https://lists.samba.org/mailman/listinfo/ccache > > _______________________________________________ ccache mailing list ccache@lists.samba.org https://lists.samba.org/mailman/listinfo/ccache
