xiangzh1 wrote: > We should add TTI check for the condition. I believe don't unroll on X86 is a > correct decision. Only like AMDGPU or NVPTX these GPU backend with heavy > stack cost need this. > > And I think you need to precommit tests first.
In fact, there is no direct/strong relation with stack cost, it mostly base on unroll or not (or other loop optimizations). Maybe we should check "unroll" info (e.g #pragma unroll) before do or not do this folding. A little trouble is loop info is not well established now. https://github.com/llvm/llvm-project/pull/74268 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
