================
@@ -11,7 +11,6 @@
 // NOINLINE-NOT: "-fsplit-dwarf-inlining"
 // SPLIT-NOT:  "-dumpdir"
 // SPLIT:      "-debug-info-kind=constructor"
-// SPLIT-SAME: "-ggnu-pubnames"
----------------
dwblaikie wrote:

Nah, I think that's probably fine without an explicit `-ggdb` test - though 
with the test as-is, wouldn't it fail on macos machines, where they'll 
implicitly default to `-glldb` and so `-ggnu-pubnames` won't get passed, so the 
check on line 14 of split-debug.c will fail? So maybe that has to be removed 
from there and only checked via explicit tuning flags, in which case adding a 
`-ggdb` test would be necessary (though it could share the CHECK lines from the 
`-glldb -ggnu-pubnames` test)

https://github.com/llvm/llvm-project/pull/83331
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to