From: Christian Kellermann <ck...@pestilenz.org>
Subject: Re: [Chicken-hackers] [PATCH] string->number shouldn't raise errors 
but return #f on failure
Date: Sat, 24 Mar 2012 19:22:31 +0100

> Hi Peter,
> 
> I have pushed your patch and dropped the C_i_ prefix from the
> internal helper procedure as discussed on #chicken.
> 
>> PS: shouldn't C_i_finitep actually be called C_u_i_finitep?
>> It's obviously unsafe (pass it any non-fixnum immediate and it'll
>> probably blow up).
> 
> I think so too, this definitely belongs to another patch. Other
> opinions?

Changing this name will create problems with older chickens that
rewrite "finite?" to C_i_finitep, so this should be better avoided.


cheers,
felix

_______________________________________________
Chicken-hackers mailing list
Chicken-hackers@nongnu.org
https://lists.nongnu.org/mailman/listinfo/chicken-hackers

Reply via email to