Comment #13 on issue 30662 by bugdro...@chromium.org: The CLD (Compact Language Library) crashes on some sites.
http://code.google.com/p/chromium/issues/detail?id=30662

The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=36460

------------------------------------------------------------------------
r36460 | jsc...@chromium.org | 2010-01-16 09:56:08 -0800 (Sat, 16 Jan 2010) | 19 lines
Changed paths:
M http://src.chromium.org/viewvc/chrome/trunk/src/base/i18n/file_util_icu.cc?r1=36460&r2=36459 M http://src.chromium.org/viewvc/chrome/trunk/src/base/string_util.cc?r1=36460&r2=36459 M http://src.chromium.org/viewvc/chrome/trunk/src/base/string_util.h?r1=36460&r2=36459 M http://src.chromium.org/viewvc/chrome/trunk/src/base/string_util_unittest.cc?r1=36460&r2=36459 M http://src.chromium.org/viewvc/chrome/trunk/src/base/utf_string_conversion_utils.h?r1=36460&r2=36459 M http://src.chromium.org/viewvc/chrome/trunk/src/base/utf_string_conversions_unittest.cc?r1=36460&r2=36459

Revert 36459 - Breaks 7 WebKit tests

Changes are:

* base::IsValidCodepoint() now returns false on noncharacter code points.
* base::IsStringUTF8() now uses ICU library (removed old Mozilla implementation).
* Removed base::IsStringWideUTF8() (was unused and confusing)
* file_util::ReplaceIllegalCharactersInPath() now treats Unicode replacement character (U+FFFD) as invalid.
* Associated unit tests updated.

BUG=2759
BUG=30662
TEST=base_unittests gtest_filter=StringUtilTest.IsStringUTF8
TEST=base_unittests gtest_filter=UTFStringConversionsTest.*
TEST=base_unittests gtest_filter=FileUtilICUTestReplaceIllegalCharactersInPathTest
Review URL: http://codereview.chromium.org/548017

tbr=jsc...@chromium.org
Review URL: http://codereview.chromium.org/552026
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
-- 
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs

Reply via email to