Who knows what needs to happen on the Chrome side for this? Is it ok for me to create a p1 bug for this and then roll the deps anyway? (The code compiles still.)
J On Wed, Jul 1, 2009 at 11:57 AM, Elliot Glaysher (Chromium) < e...@chromium.org> wrote: > > Will this let us solve http://crbug.com/1674 ? > > -- Elliot > > On Wed, Jul 1, 2009 at 11:53 AM, Peter Kasting<pkast...@google.com> wrote: > > (Wanted to make sure the right people noticed this) > > > > ---------- Forwarded message ---------- > > From: "David Hyatt" <hy...@apple.com> > > Date: Jul 1, 2009 10:04 AM > > Subject: [webkit-dev] Important change for ports regarding > FocusController > > To: "webkit-...@lists.webkit.org Development" < > webkit-...@lists.webkit.org> > > > > In order to get focus memory for tabs working properly, we need a notion > of > > whether or not the underlying Page is focused. We need this since Web > pages > > should be able to shift around programmatic focus in background tabs and > > have the new focused frame and focused node be remembered if you switch > back > > to that tab. > > > > Our current code was relying only on the window being active plus the > frame > > being focused to decide that it should draw focus rings and blink carets. > > However this isn't good enough in the case described above. > > > > I have just added a new boolean to FocusController that indicates whether > or > > not the Page is focused. The Mac and Windows ports have been patched to > > update the Page focused state properly (I hope). > > > > Other ports will need to call page->focusController()->setFocused(true) > or > > setFocused(false) now in order for everything to work properly. > > > > dave > > (hy...@apple.com) > > > > _______________________________________________ > > webkit-dev mailing list > > webkit-...@lists.webkit.org > > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > > > > > > > > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
