On Mon, Nov 2, 2009 at 2:47 PM, Drew Wilson <atwil...@chromium.org> wrote:
> I'm doing some refactoring in the chromium worker code, and I got the
> following review feedback:
> "small request: can the files that were branched from existing files be "svn
> copy'd" instead of copying manually and "svn added"? This will preserve
> history
> and will make it easier to see what changed in the review."
> Is there a way to do this with git? I do want to make my reviewers happy :)
Git has an ...odd... way of thinking about renames. The pieces you
need to know are:
1) Does git believe you did a rename? Consult "git diff -M -C --stat
origin..." and see if it prints renames.
2) If no, ping me off-list and I'll help you out.
3) If yes, Rietveld should be able to display the diff properly.
However, this code is relatively untested (we have to convert the Git
renames into SVN-style "renames" -- SVN doesn't actually support true
renames, oddly enough) so it could be wrong. In that case, also ping
me off-list. :)
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
