On Wed, Jan 13, 2010 at 9:42 AM, Evan Martin <e...@chromium.org> wrote:
> At the code level I think it's not too hard for us to be aliasing
> correct (people like Craig have already fixed all of the places where
> we were wrong, and we have tools like bit_cast<> in basictypes.h to
> make it not too painful), so I'm not too opposed to it.
>
> But on a practical note, the default only matters on Linux with gcc
> 4.4, which is not a build configuration we (Google) yet use
> extensively, which means that we break solely but frequently for
> third-party builds:
> http://code.google.com/p/chromium/issues/list?can=1&q=strict+aliasing
> (note how much of those mention "fedora" or "ubuntu")
Given your first paragraph, the comment that we're building Chrome OS with
gcc 4.4, and my own experience with aliasing-related bugs and optimizations,
I'm not sure why we shouldn't throw -fstrict-aliasing (for first-party
code). If we're already correct, this just prevents us from adding new
failures, which is a Good Thing. I don't know whether we will actually see
a perf win, but we certainly won't see a perf loss, and there's less chance
of weird, obscure bugs.
PK
--
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
