Re: [cp-patches] [RFC/PATCH 6/6] Add missing Java 1.7 java/lang/reflect/Modifier methods

[Andrew Hughes]

----- Original Message -----
> Signed-off-by: Pekka Enberg <penb...@kernel.org>
> ---
>  java/lang/reflect/Modifier.java |   42
>  ++++++++++++++++++++++++++++++++++++++-
>  1 files changed, 41 insertions(+), 1 deletions(-)
> 
> diff --git a/java/lang/reflect/Modifier.java
> b/java/lang/reflect/Modifier.java
> index 15bad05..c75f7b8 100644
> --- a/java/lang/reflect/Modifier.java
> +++ b/java/lang/reflect/Modifier.java
> @@ -1,5 +1,5 @@
>  /* java.lang.reflect.Modifier
> -   Copyright (C) 1998, 1999, 2001, 2002, 2005, 2008  Free Software
> Foundation, Inc.
> +   Copyright (C) 1998, 1999, 2001, 2002, 2005, 2008, 2012  Free
> Software Foundation, Inc.
>  
>  This file is part of GNU Classpath.
>  
> @@ -300,6 +300,46 @@ public class Modifier
>    }
>  
>    /**
> +   * @since 1.7
> +   */
> +  public static int classModifiers()
> +  {
> +    return PUBLIC | PROTECTED | PRIVATE | STATIC | ABSTRACT | FINAL
> | STRICT;
> +  }
> +
> +  /**
> +   * @since 1.7
> +   */
> +  public static int interfaceModifiers()
> +  {
> +    return PUBLIC | PROTECTED | PRIVATE | STATIC | ABSTRACT |
> STRICT;
> +  }
> +
> +  /**
> +   * @since 1.7
> +   */
> +  public static int constructorModifiers()
> +  {
> +    return PUBLIC | PROTECTED | PRIVATE;
> +  }
> +
> +  /**
> +   * @since 1.7
> +   */
> +  public static int methodModifiers()
> +  {
> +    return PUBLIC | PROTECTED | PRIVATE | STATIC | ABSTRACT | FINAL
> | STRICT | SYNCHRONIZED | NATIVE;
> +  }
> +
> +  /**
> +   * @since 1.7
> +   */
> +  public static int fieldModifiers()
> +  {
> +    return PUBLIC | PROTECTED | PRIVATE | STATIC | FINAL | TRANSIENT
> | VOLATILE;
> +  }
> +
> +  /**
>     * Get a string representation of all the modifiers represented by
>     the
>     * given int. The keywords are printed in this order:
>     * <code>&lt;public|protected|private&gt; abstract static final
>     transient
> --
> 1.7.6.5
> 
> 
> 

Looks good.
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07