----- Original Message ----- > On Tue, 17 Jul 2012, Ivan Maidanski wrote: > > Just in case you missed the patches (it seems the letter still > > waits moderator approval due > > to a 100KiB size): > >
I don't know who can moderate the list. Maybe only mjw. I remember seeing this and thought I'd replied. Some of the patches ok, others not. > > -------- Forwarded message -------- > > From: Ivan Maidanski <iv...@mail.ru> > > To: Andrew John Hughes <ahug...@redhat.com> > > CC: classpath-patches@gnu.org > > Date: Mon, 16 Jul 2012 13:59:38 +0400 > > Subject: Patch replacing all remaining .cvsignore with .gitignore > > > > Hi Andrew, > > > > On Apr 3, you committed a patch replacing root .cvsignore with > > .gitignore. > > > > I've prepared several patches to complete move to .gitignore (as > > well as to excluded some > > more auto-generated files): > > 1. Replace all .cvsignore files with .gitignore - > > https://github.com/ivmai/classpath/commit/78f20cb718daad4164da4ceac9be54185d9c78ff This seems ok. > > 2. Remove duplicate entries in .gitignore; remove empty .gitignore > > files - > > https://github.com/ivmai/classpath/commit/6479ffea252e06fd2a6c4cac024cb2696091a850 This: +.deps/ +.dirstamp +.libs/ +*.la +*.lo is wrong. .gitignore should not hide build artifacts. Those from autogen.sh are ok. > > 3. Add more auto-generated file to .gitignore - > > https://github.com/ivmai/classpath/commit/ae0451e67dc65a83b29aafa03887b432f81a6c07 > +libtool.m4 +lt*.m4 are ok as I assume they come from autogen.sh. The rest hides build artifacts. > Andrew, are you OK with me merging the above three commits to GNU > Classpath Git repository? > No, see above. Please attach patches in future rather than using links, as it's impossible to comment inline otherwise. > Pekka -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
