----- Original Message -----
> This patch fixes NPE for the following Malva test cases:
> 
>   assertEquals("false", String.format("%b", (Object[])null));
>   assertEquals("null", String.format("%h", (Object[])null));
>   assertEquals("null", String.format("%s", (Object[])null));
>   assertEquals("null", String.format("%c", (Object[])null));
>   assertEquals("null", String.format("%d", (Object[])null));
>   assertEquals("null", String.format("%o", (Object[])null));
>   assertEquals("null", String.format("%x", (Object[])null));
> 
> Signed-off-by: Pekka Enberg <penb...@kernel.org>
> ---
>  ChangeLog                |    5 +++++
>  java/util/Formatter.java |   21 ++++++++++++++++++---
>  2 files changed, 23 insertions(+), 3 deletions(-)
> 
> diff --git a/ChangeLog b/ChangeLog
> index 5690754..5a75061 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2012-03-15  Pekka Enberg  <penb...@kernel.org>
> +
> +     * java/util/Formatter.java:
> +     (format): Fix NPE errors.
> +
>  2011-07-20  Ivan Maidanski  <iv...@mail.ru>

The ChangeLogs in all these patches are incomplete.  This one
and the Collections one are particularly bad.  There are two
methods called format so it isn't clear to what this refers.
In Collections, the ChangeLog is just unreadable.
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07


Reply via email to