----- Original Message ----- > Hey guys, > My name is Farshad Muhammad and i've recently been accepted to GSoC 2013. > > I will be working to port GTK+3 AWT support for the gtk-peer in the classpath > following a migration guide provided here: > https://developer.gnome.org/gtk3/3.5/gtk-migrating-2-to-3.html > > The porting process requires the classpath first to be prepared under GTK + > 2.24 and built under certain CFLAG macros. I have successfully resolved one > of the macros which require there to be no single includes in the gtk-peer > of the classpath. > > The classpath now builds successfully using the command : > > make CFLAGS+="-DGTK_DISABLE_SINGLE_INCLUDES" > > Here is a list of changes I had to make to achieve this: > > LOG FOR SINGLE INCLUDE CHANGES: > > gtk_CairoGraphics2D.c > > Line 42: #include <gdk/gdktypes.h> to #include <gdk/gdk.h> > Line 43: #include <gdk/gdkprivate.h> to #include <gdk/gdkx.h> > > > gtk_ComponentGraphics.c > > Line 41: #include <gdk/gdktypes.h> to #include <gdk/gdk.h> > Line 44: #include <gdk/gdkprivate.h> to #include <gdk/gdkx.h> > > gtk_ComponentGraphicsCopy.c > > Line 41: #include <gdk/gdktypes.h> to #include <gdk/gdk.h> > Line 44: #include <gdk/gdkprivate.h> to #include <gdk/gdkx.h> > > gtk_ComponentPeer.c > > Line 43: #include <gtk/gtkprivate.h> to #include <gtk/gtk.h> > > gtk_VolatileImage.c > > Line 42: #include <gdk/gdktypes.h> to #include <gdk/gdk.h> > Line 45: #include <gdk/gdkprivate.h> to #include <gdk/gdkx.h> > > I would like to commit these changes as a classpath patch. > > >
Hi Farshad, First of all, welcome to the project and I hope you enjoy working with us for Google's Summer of Code. For your patch, you should attach the output of 'git diff' to your mail. You also need to make the CFLAGS change permanent in the Makefile.am. Each change also needs a ChangeLog entry. You can look in the file ChangeLog for examples and add yours there. Include the entry in the mail but not as part of the attached patch (though it should be part of the final commit), as this makes it easier for others to apply and test your patch. Thanks and congratulations on your first contribution! -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07
