On Tue, 2 Jan 2024 15:03:12 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:

> The new test java/awt/font/JNICheck/FreeTypeScalerJNICheck.java introduced 
> with https://bugs.openjdk.java.net/browse/JDK-8269223 adds -Xcheck:jni , and 
> shows on Windows server 2019 the following JNI warning , so the test fails on 
> this Windows version.
> 
>  stdout: [WARNING in native method: JNI call made without checking exceptions 
> when required to from CallStaticVoidMethodV
>       at 
> sun.awt.Win32GraphicsEnvironment.initDisplay(java.desktop@23-internal/Native 
> Method)
>       at 
> sun.awt.Win32GraphicsEnvironment.initDisplayWrapper(java.desktop@23-internal/Win32GraphicsEnvironment.java:95)
>       at 
> sun.awt.Win32GraphicsEnvironment.<clinit>(java.desktop@23-internal/Win32GraphicsEnvironment.java:63)
>       at 
> sun.awt.PlatformGraphicsInfo.createGE(java.desktop@23-internal/PlatformGraphicsInfo.java:34)
>       at 
> java.awt.GraphicsEnvironment$LocalGE.createGE(java.desktop@23-internal/GraphicsEnvironment.java:93)
>       at 
> java.awt.GraphicsEnvironment$LocalGE.<clinit>(java.desktop@23-internal/GraphicsEnvironment.java:84)
>       at 
> java.awt.GraphicsEnvironment.getLocalGraphicsEnvironment(java.desktop@23-internal/GraphicsEnvironment.java:106)
>       at FreeTypeScalerJNICheck.runTest(FreeTypeScalerJNICheck.java:53)
>       at FreeTypeScalerJNICheck.main(FreeTypeScalerJNICheck.java:44)
> 
> 
> We better add an exception check to get rid of the JNI warning (and also of 
> the test failure) .

Hi Phil,

sorry for this, this was not bad intent, just a plain mistake. It is somewhat 
difficult to remember the exact review rules per project. Help from Skara would 
certainly be useful here.

Cheers, Thomas

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17224#issuecomment-1883471813

Reply via email to