> On Aug. 10, 2012, 5:13 p.m., edison su wrote: > > raw2qcow2 is missing? Please resend the patch ASAP, the 4.0 will be > > branched.
It's not necessary at this point. it's basically a hook that will allow us to do something smarter than a qemu-img convert (say fill the source raw image empty space with zeros beforehand to get the best sparse qcow2 image) if we choose. Without the file, it defaults to a normal qemu-img convert from raw to qcow2. If you'd prefer this be left out, I can easily remove it and resubmit the patch. - Marcus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6470/#review10131 ----------------------------------------------------------- On Aug. 8, 2012, 3:11 p.m., Marcus Sorensen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6470/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2012, 3:11 p.m.) > > > Review request for cloudstack. > > > Description > ------- > > Adds CLVM as an option for primary storage. It copies most of the RBD bits, > in most cases simply adding an 'else if' or similar. In the managesnapshot.sh > we add the ability to manipulate snapshots for the CLVM volumes, as well as a > few minor fixes like adjusting the usage for the -b option to reflect that it > accepts four arguments (note that it already accepted four args, it just > wasn't reflected in the usage). > > > Diffs > ----- > > api/src/com/cloud/storage/Storage.java d6bd04e > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java > 359497e > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStoragePoolManager.java > 491f772 > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java > 85c64ba > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStoragePool.java > bc428e1 > scripts/storage/qcow2/managesnapshot.sh a305ba8 > server/src/com/cloud/storage/StorageManagerImpl.java c7dda00 > ui/scripts/system.js de0ce4d > ui/scripts/zoneWizard.js 261668f > > Diff: https://reviews.apache.org/r/6470/diff/ > > > Testing > ------- > > Create system VMs on CLVM : passed > Create instances on CLVM : passed > Create data volumes on CLVM : passed > Delete CLVM data volumes : passed > New CLVM vol snapshot : passed > Create CLVM vol from snapshot : passed > > > Thanks, > > Marcus Sorensen > >
