----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6895/#review11405 -----------------------------------------------------------
Pushed the changes to asf/autoscale. Please mark the ticket as submitted. Thanks ! - Pranav Saxena On Sept. 11, 2012, 9:11 p.m., Vijay Venkatachalam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6895/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2012, 9:11 p.m.) > > > Review request for cloudstack, Devdeep Singh and Deepak Garg. > > > Description > ------- > > 1. Better names for default counters (removed special characters etc) > 2. Aligning the Netscaler response time counter to the right unit. > (changing from milliseconds to microseconds) > 3. Duration cannot be less than interval and making QuietTime independent > of interval. > > > This addresses bug CS-15729. > > > Diffs > ----- > > server/src/com/cloud/network/as/AutoScaleManagerImpl.java 8c39097 > setup/db/create-schema.sql 2b0b01a > > Diff: https://reviews.apache.org/r/6895/diff/ > > > Testing > ------- > > 1. deploydb succeeds. > 2. Testing duration check. > a. create autoscale config (duration=300), (interval=30) > b. fire updateAutoScalePolicy with duration=25. #checks update path. > 3. Testing quiettime independency. > a. create autoscale config (quiettime=25), (interval=30) #verifies > create path > b. fire updateAutoScalePolicy with quiettime=24. #verifies update path > > > Thanks, > > Vijay Venkatachalam > >
