----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9396/#review16419 -----------------------------------------------------------
Agree with David. There are several new class files, many of which have logic in them, so I would expect to see unit tests that cover those classes (especially those methods with logic). - Chip Childers On Feb. 10, 2013, 9:12 a.m., Jayapal Reddy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9396/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2013, 9:12 a.m.) > > > Review request for cloudstack. > > > Description > ------- > > Using this feature we can reserve secondary ip addresses for guest vm nic. > Administrator will configure the these ip addresses on the nic manually. > > > This addresses bug CLOUDSTACK-24. > > > Diffs > ----- > > api/src/com/cloud/network/IpAddress.java 47df4d6 > api/src/com/cloud/network/NetworkService.java ace1bb6 > api/src/com/cloud/network/rules/RulesService.java 921a86e > api/src/com/cloud/vm/Nic.java 9d21130 > api/src/com/cloud/vm/NicSecondaryIp.java PRE-CREATION > api/src/org/apache/cloudstack/api/ApiConstants.java d29408e > api/src/org/apache/cloudstack/api/ResponseGenerator.java 0dc85de > > api/src/org/apache/cloudstack/api/command/user/firewall/CreatePortForwardingRuleCmd.java > 39ab812 > > api/src/org/apache/cloudstack/api/command/user/loadbalancer/AssignToLoadBalancerRuleCmd.java > e0f9bcd > api/src/org/apache/cloudstack/api/command/user/nat/EnableStaticNatCmd.java > ce6ea16 > api/src/org/apache/cloudstack/api/command/user/vm/AddIpToVmNicCmd.java > PRE-CREATION > api/src/org/apache/cloudstack/api/command/user/vm/ListNicsCmd.java > PRE-CREATION > > api/src/org/apache/cloudstack/api/command/user/vm/ListSecondaryIPToNicCmd.java > PRE-CREATION > api/src/org/apache/cloudstack/api/command/user/vm/RemoveIpFromVmNicCmd.java > PRE-CREATION > api/src/org/apache/cloudstack/api/command/user/vm/RemoveNicFromVMCmd.java > b1a870e > api/src/org/apache/cloudstack/api/response/AddIpToVmNicResponse.java > PRE-CREATION > api/src/org/apache/cloudstack/api/response/IPAddressResponse.java 251b2dd > api/src/org/apache/cloudstack/api/response/ListNicSecondaryIpResponse.java > PRE-CREATION > api/src/org/apache/cloudstack/api/response/NicResponse.java a7d1a0d > client/tomcatconf/commands.properties.in d70649b > server/src/com/cloud/api/ApiDBUtils.java 83132c6 > server/src/com/cloud/api/ApiResponseHelper.java 8c97615 > server/src/com/cloud/network/NetworkManager.java 2904183 > server/src/com/cloud/network/NetworkManagerImpl.java 7a6ac27 > server/src/com/cloud/network/NetworkModelImpl.java ce48e84 > server/src/com/cloud/network/NetworkServiceImpl.java 050a1fe > server/src/com/cloud/network/addr/PublicIp.java 7336c9c > server/src/com/cloud/network/dao/IPAddressDao.java 9cdb975 > server/src/com/cloud/network/dao/IPAddressDaoImpl.java e7067d9 > server/src/com/cloud/network/dao/IPAddressVO.java 00da5eb > server/src/com/cloud/network/dao/LoadBalancerVMMapVO.java 8856993 > server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java 85e850c > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > 1abca51 > server/src/com/cloud/network/rules/RulesManagerImpl.java 0a00d22 > server/src/com/cloud/network/rules/dao/PortForwardingRulesDao.java 91f08e7 > server/src/com/cloud/network/rules/dao/PortForwardingRulesDaoImpl.java > 5406ab6 > server/src/com/cloud/vm/NicVO.java 8e2edda > server/src/com/cloud/vm/UserVmManagerImpl.java 33a53d9 > server/src/com/cloud/vm/dao/NicDao.java 762048b > server/src/com/cloud/vm/dao/NicDaoImpl.java 5cf152f > server/src/com/cloud/vm/dao/NicSecondaryIpDao.java PRE-CREATION > server/src/com/cloud/vm/dao/NicSecondaryIpDaoImpl.java PRE-CREATION > server/src/com/cloud/vm/dao/NicSecondaryIpVO.java PRE-CREATION > server/test/com/cloud/network/MockNetworkManagerImpl.java 4a24f9a > server/test/com/cloud/network/MockRulesManagerImpl.java ba3dd41 > server/test/com/cloud/vpc/MockNetworkManagerImpl.java bcaaa26 > setup/db/create-schema.sql f89c885 > setup/db/db/schema-40to410.sql d771a15 > > Diff: https://reviews.apache.org/r/9396/diff/ > > > Testing > ------- > > Tested add adding, deleting and listing addresses on the nic using APIs > > > Thanks, > > Jayapal Reddy > >
