Hiroaki I was going through the review board and this is still pending. Can you review and respond to reviewer comments?
Animesh > -----Original Message----- > From: Rohit Yadav [mailto:nore...@reviews.apache.org] On Behalf Of Rohit > Yadav > Sent: Tuesday, January 08, 2013 8:17 PM > To: cloudstack; Hiroaki Kawai; Rohit Yadav > Subject: Re: Review Request: Default admin user account will not be created in > clean setup > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8293/#review15169 > ----------------------------------------------------------- > > > Any update on this one? > > - Rohit Yadav > > > On Nov. 30, 2012, 11:09 a.m., Hiroaki Kawai wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/8293/ > > ----------------------------------------------------------- > > > > (Updated Nov. 30, 2012, 11:09 a.m.) > > > > > > Review request for cloudstack. > > > > > > Description > > ------- > > > > Current com.cloud.server.ConfigurationServerImpl#saveUser tries to insert > an admin user entity into database, but the sql leaves password field > unspecified. This will always fail because the database schema declares > password field NOT NULL. This patch will fix database schema, and add missing > logging when this sql execution failed. > > > > This happens only on current master:HEAD. > > > > > > Diffs > > ----- > > > > server/src/com/cloud/server/ConfigurationServerImpl.java d2f0bb0 > > setup/db/create-schema.sql fff084e > > > > Diff: https://reviews.apache.org/r/8293/diff/ > > > > > > Testing > > ------- > > > > > > Thanks, > > > > Hiroaki Kawai > > > >