Bharat – can you please fix the issues and resend it please ? Nitins-MacBook-Air:incubator-cloudstack nitinmehta$ git apply --whitespace=fix ../CS-14673.patch ../CS-14673.patch:19: trailing whitespace.
../CS-14673.patch:22: trailing whitespace. error: patch failed: server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java:109 error: server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java: patch does not apply error: patch failed: server/src/com/cloud/template/HyervisorTemplateAdapter.java:219 error: server/src/com/cloud/template/HyervisorTemplateAdapter.java: patch does not apply error: patch failed: server/src/com/cloud/template/TemplateManagerImpl.java:843 error: server/src/com/cloud/template/TemplateManagerImpl.java: patch does not apply From: Nitin Mehta <nitin.me...@citrix.com<mailto:nitin.me...@citrix.com>> Reply-To: Nitin Mehta <nitin.me...@citrix.com<mailto:nitin.me...@citrix.com>> To: Nitin Mehta <nitin.me...@citrix.com<mailto:nitin.me...@citrix.com>> Cc: "cloudstack-dev@incubator.apache.org<mailto:cloudstack-dev@incubator.apache.org>" <cloudstack-dev@incubator.apache.org<mailto:cloudstack-dev@incubator.apache.org>>, Bharat Kumar <bharat.ku...@citrix.com<mailto:bharat.ku...@citrix.com>> Subject: Re: Review Request: when a template is deleted and then copied over again , it is still marked as "Removed" in template_zone_ref table. This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7018/ Ship it! Ship It! - Nitin On January 13th, 2013, 5:14 p.m., bharat kumar wrote: Review request for cloudstack and Nitin Mehta. By bharat kumar. Updated Jan. 13, 2013, 5:14 p.m. Description This bug fix (CLOUDSTACK-970) deals with the database aspects of template creation, this changes the way in which the entries are added and removed from template_zone_ref and template_host_ref. Testing I have tested this on the asf branch. Diffs * server/src/com/cloud/storage/dao/VMTemplateDaoImpl.java (2a0dfc8) * server/src/com/cloud/template/HyervisorTemplateAdapter.java (bdb89f6) * server/src/com/cloud/template/TemplateManagerImpl.java (1e87de2) View Diff<https://reviews.apache.org/r/7018/diff/>
