-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9749/#review17409
-----------------------------------------------------------
Ship it!
Applied to 4.1 branch:
commit bf40ab48f2af9368b391995ffde2f9e0a3877b48
Author: Kishan Kavala <kis...@cloud.com>
Date: Tue Mar 5 17:19:03 2013 +0530
CLOUDSTACK-1473: cleanp flag is optional param for deleteDomain API. Check
for null before converting it to string
- Chip Childers
On March 5, 2013, 11:55 a.m., Kishan Kavala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9749/
> -----------------------------------------------------------
>
> (Updated March 5, 2013, 11:55 a.m.)
>
>
> Review request for cloudstack and Chip Childers.
>
>
> Description
> -------
>
> cleanp flag is optional param for deleteDomain API.
> Check for null before converting it to string to avoid NPE.
>
>
> This addresses bug CLOUDSTACK-1473.
>
>
> Diffs
> -----
>
> server/src/org/apache/cloudstack/region/RegionManagerImpl.java b4b55fd
>
> Diff: https://reviews.apache.org/r/9749/diff/
>
>
> Testing
> -------
>
> Tested domain deletion with and without cleanup flag.
>
>
> Thanks,
>
> Kishan Kavala
>
>
