----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9890/#review17808 -----------------------------------------------------------
Commit 05f73d0950d3a12591facce03e43201e2fbbff17 in branch refs/heads/master from Min Chen <min.c...@citrix.com> [ https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;h=05f73d0 ] CLOUDSTACK-1656: NicResponses in a UserVmResponse are not preseving the natural order. - ASF Subversion and Git Services On March 13, 2013, 1:08 a.m., Min Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9890/ > ----------------------------------------------------------- > > (Updated March 13, 2013, 1:08 a.m.) > > > Review request for cloudstack and Chip Childers. > > > Description > ------- > > For a UserVm with multiple Nics, listVMCmd will return this VM with > NicResponses in reverse order, not ordered by device_id of Nic table. This > patch fixed this issue by using LinkedHashSet instead of HashSet to preserve > insertion order. > > > This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1656. > > > Diffs > ----- > > api/src/org/apache/cloudstack/api/response/DomainRouterResponse.java > 274e7a5 > api/src/org/apache/cloudstack/api/response/SecurityGroupResponse.java > 1130ec0 > api/src/org/apache/cloudstack/api/response/UserVmResponse.java cb2113e > api/src/org/apache/cloudstack/api/response/VolumeResponse.java b10da0c > > Diff: https://reviews.apache.org/r/9890/diff/ > > > Testing > ------- > > Tested locally. > > > Thanks, > > Min Chen > >
