----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9752/#review18073 -----------------------------------------------------------
test/integration/component/test_snapshots_improvements.py <https://reviews.apache.org/r/9752/#comment38161> Make sure you aren't leaving any unused service dictionaries. test/integration/component/test_snapshots_improvements.py <https://reviews.apache.org/r/9752/#comment38160> The url appears to be local. Also - the windows template test will not be checked by cloudstack. So this can be any vhd. Use the default builtin CentOS vhd for this test? test/integration/component/test_snapshots_improvements.py <https://reviews.apache.org/r/9752/#comment38162> can you fix the trailing spaces in this patch? git apply --whitespace=fix your.patch should take care of this. test/integration/component/test_snapshots_improvements.py <https://reviews.apache.org/r/9752/#comment38164> Can you put a FIXME: JIRA issue CLOUDSTACK-601? test/integration/component/test_snapshots_improvements.py <https://reviews.apache.org/r/9752/#comment38165> The test runner code (__main__) can be gotten rid of. It's not required when the test runs on test infra. - Prasanna Santhanam On March 19, 2013, 12:45 p.m., sanjeev n wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9752/ > ----------------------------------------------------------- > > (Updated March 19, 2013, 12:45 p.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Description > ------- > > Added two test cases for snapshots improvement feature. > > > Diffs > ----- > > test/integration/component/test_snapshots_improvements.py PRE-CREATION > > Diff: https://reviews.apache.org/r/9752/diff/ > > > Testing > ------- > > Executed the tests in advanced zone setup. > > > Thanks, > > sanjeev n > >
