----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10022/ -----------------------------------------------------------
Review request for cloudstack. Summary (updated) ----------------- (CLOUDSTACK-1668) Fix IP conflict in VPC tier on master/4.1 Description (updated) ------- Currently, allPossibleIps return the Ip lists which include the gateway, so we need to remove gateway ip from this list. Now, for non-VPC network it works, because NetUtils.getAllIpsFromCidr return the Ip lists which do not include the first IP of the network (like 192.168.0.1). We need too add the first IP into the returned Ip list, because it can be used for VM if it is not the gateway IP (for example, VPC networks). The corresponding patch for 4.0.1 has been posted on https://reviews.apache.org/r/9923/ This addresses bug CLOUDSTACK-1668. Diffs (updated) ----- server/src/com/cloud/network/NetworkModelImpl.java 779b9f2 server/src/com/cloud/network/NetworkServiceImpl.java 52e81e5 utils/src/com/cloud/utils/net/NetUtils.java dd40a33 Diff: https://reviews.apache.org/r/10022/diff/ Testing ------- Thanks, Wei Zhou
