----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10036/#review18133 -----------------------------------------------------------
Ship it! applied to 4.1 and master. thanks - Chip Childers On March 20, 2013, 12:03 a.m., Min Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10036/ > ----------------------------------------------------------- > > (Updated March 20, 2013, 12:03 a.m.) > > > Review request for cloudstack and Chip Childers. > > > Description > ------- > > This patch fixed two bugs (CLOUDSTACK-1446 and CLOUDSTACK-1511), I combined > them into one patch since they will touch the same schema-40to410.sql. These > two bugs are caused by some minor bugs introduced in creating user_vm_view > and domain_router_view db views. > > > This addresses bugs and, > https://issues.apache.org/jira/browse/CLOUDSTACK-1446 and > https://issues.apache.org/jira/browse/CLOUDSTACK-1511. > > > Diffs > ----- > > server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java f561449 > server/src/com/cloud/api/query/vo/UserVmJoinVO.java d723822 > setup/db/db/schema-40to410.sql b253663 > > Diff: https://reviews.apache.org/r/10036/diff/ > > > Testing > ------- > > Tested locally. > > > Thanks, > > Min Chen > >