Kelven, I see that you fixed action event issue in below commit. But I am still running into some issues. While working on CLOUDSTACK-1673 I noticed that in case of AccountManagerImpl, there are multiple methods with same name. So in that case getAnnotation on the method is returning null even though there is ActionEvent annotation. If I rename method then action event annotation works fine. You can repro it by creating user (there are two createUser methods in AccountManagerImpl). I looked at ComponentMethodProxyCache to see if I can figure the problem but with no luck. If you get a chance please try once.
On 19/03/13 6:44 AM, "kelv...@apache.org" <kelv...@apache.org> wrote: >Updated Branches: > refs/heads/master d9b85e397 -> fb94b7221 > > >CLOUDSTACK-1568,CLOUDSTACK-1664: Fix ActionEvent interception and >optimize @DB lookup with caching > > >Project: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo >Commit: >http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/commit/fb94b72 >2 >Tree: >http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/tree/fb94b722 >Diff: >http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/diff/fb94b722 > >Branch: refs/heads/master >Commit: fb94b72213bf96f2878b90260067f61629c6a956 >Parents: d9b85e3 >Author: Kelven Yang <kelv...@gmail.com> >Authored: Mon Mar 18 18:05:09 2013 -0700 >Committer: Kelven Yang <kelv...@gmail.com> >Committed: Mon Mar 18 18:07:52 2013 -0700 > >---------------------------------------------------------------------- > .../com/cloud/event/ActionEventInterceptor.java | 15 ++- > .../ConsoleProxyHttpHandlerHelper.java | 14 ++- > .../utils/component/ComponentMethodProxyCache.java | 90 +++++++++++++++ > .../utils/component/SpringComponentScanUtils.java | 1 - > .../cloud/utils/db/TransactionContextBuilder.java | 14 +-- > 5 files changed, 119 insertions(+), 15 deletions(-) >---------------------------------------------------------------------- >
