uh, sorry about the noise, you are right, the patch is completely bogus. I wonder where it converts it to a path, will have to look into a bit more.
thanks /Johan On Fri, May 27, 2011 at 12:17 PM, David Cole <david.c...@kitware.com> wrote: > This patch can't quite be right. > > After this patch, the value of CMAKE_OSX_SYSROOT will be: > "macosx10.5;STRING;PATH;The product will be built agai..." > > You meant to change the "PATH" to a "STRING" I think -- but even so, > this change should have no actual effect on the behavior of CMake. The > type of a variable is merely a hint to the gui programs on what type > of edit control to use for editing the variable's value. Aside from > that, there should be no observable effect. > > The effect you're seeing as a result of this mistaken patch is > probably due to the fact that CMAKE_OSX_SYSROOT is not being *cached* > anymore, not because you've changes a cache entry's type.... > > I am afraid we'll have to do a round of fixes for Xcode 4 support if > it no longer accepts full path to the SDK as a valid value for this > property. > > > On Fri, May 27, 2011 at 5:54 AM, Johan Björk <p...@spotify.com> wrote: >> Hi guys, >> >> Attached patch that changes the type of the CMAKE_OSX_SYSROOT >> variable. All versions of XCode accept in addition to the full path to >> the SDK, also a symbolic name, ie 'macosx10.5' or similar. To make >> things worse, some versions of XCode 4 doesn't seem to like the full >> paths at all. >> >> Without this patch, it already works fine, until you try to use >> TRY_COMPILE() or the like, where your symbolic name will be converted >> to a full path. >> '/Users/phb/DEV/.../build/CMakeFiles/CMakeTmp/CMakeFiles/CMakeTmp/macosx10.5' >> >> Should be a trivial fix, there should be no reason where we want >> automatic path expansion on that value. >> >> Thanks >> /Johan >> >> _______________________________________________ >> cmake-developers mailing list >> cmake-developers@cmake.org >> http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers >> >> > _______________________________________________ cmake-developers mailing list cmake-developers@cmake.org http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
