David Cole wrote: > On Sun, Jan 29, 2012 at 11:44 AM, Stephen Kelly > <steve...@gmail.com> wrote: >> David Cole wrote: >>> OK... nearly complete now. Please review, then reply and tell me if >>> you object to any of the 7 commits in this topic branch. >> >> No objections. They all seem fine. >> > > Great, thanks. > > >>> Steve, I've >>> preserved your authorship for most of these commits, but have >>> significantly re-written some of them. >> >> The 3 following 073bc421620e25fef6389b0d8b71cfad8ca79786 (CMake: >> Eliminate cmMakefile::IncludeDirectories) seem to have been substantially >> re-written. I'm not sure what is the appropriate way to deal with commits >> like that, but whatever you choose for the author line is fine. >> > > So I guess the question is: if somebody looks up the author at some > point in the future and comes asking a question, do you want to be the > one they go to, or would you rather have them come to me? ;-) If you > want to send them to me, I'll change the author line, but you > certainly deserve the credit for getting the ball rolling on this > topic.
Ok, let's leave it as-is and I'll take responsibility (blame/credit) :) <snip> >>> - double-check with Alex about the changes in cmake::FindPackage -- >>> Alex? Still pending. > Thanks -- I'll pull this and use it as a basis for the final topic. Great. Let me know if there's any more I can do. Thanks, Steve. -- Powered by www.kitware.com Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Follow this link to subscribe/unsubscribe: http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
