On 6/26/2012 2:25 PM, Claus Klein wrote:
Hi Dave,
I found one more Ninja issue;
The Ninja Eclipse Generator crashes while make target generation. No
Idea why, but this helps for now:
Can you give a way to reproduce the problem?
diff --git a/Source/cmExtraEclipseCDT4Generator.cxx
b/Source/cmExtraEclipseCDT4Generator.cxx
index ab11307..b9e360b 100644
--- a/Source/cmExtraEclipseCDT4Generator.cxx
+++ b/Source/cmExtraEclipseCDT4Generator.cxx
@@ -964,6 +964,11 @@ void
cmExtraEclipseCDT4Generator::CreateCProjectFile() const
it != this->GlobalGenerator->GetLocalGenerators().end();
++it)
{
+ if (std::string("Ninja") == generator->GetName())
+ {
+ break; // FIXME with Ninja it crashes! For now not relay
needed! ck
+ }
+
const cmTargets& targets = (*it)->GetMakefile()->GetTargets();
cmMakefile* makefile=(*it)->GetMakefile();
std::string subdir =
(*it)->Convert(makefile->GetCurrentOutputDirectory(),
claus-kleins-macbook-pro:cmake clausklein$
//Regards
Claus
On 26.06.2012, at 16:39, David Cole wrote:
Thanks.
I've pushed a fix and merged it to 'next' -- we'll get it into rc2.
http://cmake.org/gitweb?p=3Dcmake.git;a=3Dcommitdiff;h=3Db163c45445ce75eb=
68d0835b24d4c90ad5b9f6f7
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
--
Bill Hoffman
Kitware, Inc.
28 Corporate Drive
Clifton Park, NY 12065
bill.hoff...@kitware.com
http://www.kitware.com
518 881-4905 (Direct)
518 371-3971 x105
Fax (518) 371-4573
--
Powered by www.kitware.com
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers
