On 8/13/2012 10:54 AM, Stephen Kelly wrote:
Bill Hoffman wrote:

There is a new failure here:
http://open.cdash.org/testDetails.php?test=156059931&build=2506673


Is the output truncated somehow, or is that really all of it?
I ran it in a debugger, and cmake was crashing, this fixed it, but I don't think it is the right fix, but should let you know what is going on:


diff --git a/Source/cmNinjaTargetGenerator.cxx b/Source/cmNinjaTargetGenerator.c
index 3532c8b..1e1c326 100644
--- a/Source/cmNinjaTargetGenerator.cxx
+++ b/Source/cmNinjaTargetGenerator.cxx
@@ -398,7 +398,7 @@ cmNinjaTargetGenerator

   if(useClDeps)
     {
-    std::string cl = mf->GetDefinition("CMAKE_C_COMPILER");
+    std::string cl = mf->GetSafeDefinition("CMAKE_C_COMPILER");
     cl = "\"" + cl + "\" ";
     cmdLine =   clDepsBinary + " " + lang + " $in \"$DEP_FILE\" $out "
               + clShowPrefix + " " + cl   + cmdLine;

mf->GetDefinition("CMAKE_C_COMPILER"); is returning null when cmake is running on the test binary tree.

-Bill


--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to