Here's the updated patch file with tests added. Let me know if it's good to go.
-----Original Message----- From: Brad King [mailto:brad.k...@kitware.com] Sent: Thursday, June 11, 2015 8:55 AM To: Robert Goulet Cc: cmake-developers@cmake.org Subject: Re: [cmake-developers] Generator expressions for output directory/name (and install?) On 06/10/2015 01:43 PM, Robert Goulet wrote: > Ok I think I got something nicely integrated now. Thanks. Here are some comments: > + std::string GetDestination(const char* config=nullptr) const; Please avoid C++11 constructs. > +std::string cmInstallGenerator::GetDestination(const char* config) > +const { > + std::string configName = config ? config : ConfigurationName; This should be able to use "std::string const&" as the argument type instead. Just have the call sites pass ConfigurationName themselves or create an argument-less overload that passes it for them. Also please look at updating the test suite to cover this. The Tests/ExportImport test has Export and Import sub-projects that test installation of all kinds of targets. That may be a good place to add tests for DESTINATION. Thanks, -Brad
more-generator-expressions.patch
Description: more-generator-expressions.patch
-- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
