Is the patch applied? Let me know if there are any questions left about it.
On 15-Jun-16 23:38, Ruslan Baratov via cmake-developers wrote:
On 15-Jun-16 22:59, Gregor Jasny wrote:
Hello,
Thanks for the patch!
On 15/06/16 16:41, Ruslan Baratov wrote:
Sending some fixes found by testing with Xcode 7.3
We were chasing some errors regarding the unified build some time ago.
But it appeared some for of heisenbug: the more I looked the less likely
it happened.
Is the error 100% reproducible for you?
Yes - for the Travis VM with xcode7.3 image. Not - for my local machine.
And do you know what goes wrong?
Yes, I've leaved a note in the comments section. There are some
messages in error stream, they are not related to lipo location. Here
is example of the log with error:
CMake Error at
/Users/travis/build/ingenue/hunter/_ci/cmake/share/cmake-3.5/Modules/CMakeIOSInstallCombined.cmake:102
(message):
Command failed (File name too long): 2016-05-31 18:37:15.058
xcodebuild[6590:18239] Build settings from command line:
2016-05-31 18:37:15.059 xcodebuild[6590:18239] TOOLCHAINS =
com.apple.dt.toolchain.XcodeDefault
2016-05-31 18:37:15.059 xcodebuild[6590:18239]
XCODE_DEFAULT_TOOLCHAIN_OVERRIDE =
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo;-info;/Users/travis/build/ingenue/hunter/_testing/Hunter/_Base/7f9eaa4/f53c868/1c14a4b/Build/GTest/Build/GTest-Release-prefix/src/GTest-Release-build/googlemock/Release-iphonesimulator/libgmock.a
Does the
list(LENGTH _lipo_path len)
if(NOT len EQUAL 1)
take paths with spaces into account?
Nope as far as I know. In fact it doesn't catch the error I've seen, I
decide to add some sanity checks just to be sure.
Ruslo
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
