-------- sending message --------
05.07.2016, 22:37, "Konstantin Podsvirov" <konstan...@podsvirov.pro>:
Thanks, Brad!
I've been waiting for your answer :-)
05.07.2016, 22:30, "Brad King" <git...@gitlab.kitware.com>:
> Thanks. I've merged this to next for testing.
I found a small bug in CPackIFW. The patch is attached.
I read the wrong documentation for QtIFW
(https://bugreports.qt.io/browse/QTIFW-873) and made the wrong generation.
I conducted a series of tests and now everything should work correctly.
I have a household question:
Changes are best to send to a mailing list or use your gitlab?
-------- sending message --------
Regards,
Konstantin Podsvirov
From e52011d61867db107c3437d7e55e02bcdc555f41 Mon Sep 17 00:00:00 2001
From: Konstantin Podsvirov <konstan...@podsvirov.pro>
Date: Tue, 5 Jul 2016 22:30:12 +0300
Subject: [PATCH 3/3] CPackIFW: Fixed attributes for repository replace
---
Source/CPack/IFW/cmCPackIFWRepository.cxx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Source/CPack/IFW/cmCPackIFWRepository.cxx b/Source/CPack/IFW/cmCPackIFWRepository.cxx
index ee6d5e5..fcb1c77 100644
--- a/Source/CPack/IFW/cmCPackIFWRepository.cxx
+++ b/Source/CPack/IFW/cmCPackIFWRepository.cxx
@@ -299,8 +299,8 @@ void cmCPackIFWRepository::WriteRepositoryUpdate(cmXMLWriter& xout)
if (Update == Add || Update == Remove) {
xout.Attribute("url", Url);
} else if (Update == Replace) {
- xout.Attribute("oldurl", OldUrl);
- xout.Attribute("newurl", NewUrl);
+ xout.Attribute("oldUrl", OldUrl);
+ xout.Attribute("newUrl", NewUrl);
}
// Enabled
if (!Enabled.empty()) {
--
2.8.3.windows.1
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
