Paul Smith <p...@mad-scientist.net> writes: > On Sun, 2013-11-17 at 20:03 +0200, Raphael Kubo da Costa wrote: >> Roy Crihfield <rscr...@gmail.com> writes: >> >> > I have a patch the the CMake emacs mode I'd like to have reviewed and >> > push. What is the preferred way to do this - should I just send the >> > patch, or fork and push to the repository? >> >> Both sending a patch to cmake-devel via `git patch' and sending a pull >> request with GitHub should work fine. > > I haven't created a patch for it, but the keymap provided with cmake > mode needs to be changed: > > (defvar cmake-mode-map > (let ((map (make-sparse-keymap))) > (define-key map "\C-ch" 'cmake-help-command) > (define-key map "\C-cl" 'cmake-help-list-commands) > (define-key map "\C-cu" 'unscreamify-cmake-buffer) > map) > "Keymap used in cmake-mode buffers.") > > This is not good: All keys C-c <letter> are reserved for users for their > local commands and are not supposed to be mapped by any other modes.
I'm not sure if this is what Roy originally had in mind; it would be good if you could file a bug in CMake's bug tracker for this in any case. And FWIW, when I said `git patch' I had `git send-email' in mind. -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://www.cmake.org/mailman/listinfo/cmake