DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20296>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20296 [PATCH] Modularized DirectoryGenerator's ------- Additional Comments From [EMAIL PROTECTED] 2003-06-28 10:53 ------- Hello Torsten, I had a look at your code - and I'm not convinced. You extracted an interface out of the DirectoryGenerator and added a AbstractFileHandler, the old extending generators like MP3DG or ImageDG are reimplemented as FileHandlers. But what's the advantage of this, what are the use cases, where current DirectoryGenerator does not work? We don't have any duplicate code in the current implementation, so the simple design (a base class and some extending classes) seems to be really good. Of course modularization is good, but not always - exactly there where it is not really needed. Or to speak in XP: YAGNI (http://www.xprogramming.com/Practices/PracNotNeed.html) + KISS (http://www.extremeprogramming.org/rules/simple.html). Do you still want to convince me? ;-) At the best with use cases. Also Conal voted for this bug and Miles added his mail address as CC - maybe they know use cases. And furthermore something is completely missing in your patches: documentation - no Javadoc, no XDocs, no anything. Maybe someone else can have a look on this, but I'm about to reject the patch. Joerg
