[
https://issues.apache.org/jira/browse/CASSANDRA-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14370665#comment-14370665
]
Jeff Jirsa edited comment on CASSANDRA-5791 at 3/26/15 3:25 AM:
----------------------------------------------------------------
So the same bug corrected in CASSANDRA-8778 was re-introduced by CASSANDRA-8709
.
I've done the following:
1) Rebased to trunk as of 20150325
2) Removed o.a.c.io.DataIntegrityMetadata#append
3) Corrected o.a.c.io.DataIntegrityMetadata#appendDirect
4) Brought over [~benedict]'s PureJavaCRC32 's fix from above (which was
correct - 7bef6f93aea3a6897b53e909688f5948c018ccdf)
Commit:
https://github.com/jeffjirsa/cassandra/commit/daaa88878c023fbcd94d4aa7d02696a675a118dd
Diff at
https://github.com/apache/cassandra/compare/trunk...jeffjirsa:cassandra-5791.diff
,
Passing:
{noformat}
[junit] ------------- ---------------- ---------------
[junit] Testsuite: org.apache.cassandra.db.VerifyTest
[junit] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
2.803 sec
[junit]
{noformat}
[~jbellis] and [~benedict] - if you want unit tests for DataIntegrityMetadata,
Jira it, assign me, and I'll write them. I'd have done it tonight but I can't
convince myself that they're not redundant with the (included) verifier unit
tests which will test the checksums anyway.
(Will continue rebasing every few days as required - latest rebase 20150325,
pull latest from github rather than using attached files)
was (Author: jjirsa):
So the same bug corrected in CASSANDRA-8778 was re-introduced by CASSANDRA-8709
.
I've done the following:
1) Rebased to trunk as of 20150319
2) Removed o.a.c.io.DataIntegrityMetadata#append
3) Corrected o.a.c.io.DataIntegrityMetadata#appendDirect
4) Brought over [~benedict]'s PureJavaCRC32 's fix from above (which was
correct - 7bef6f93aea3a6897b53e909688f5948c018ccdf)
Commit:
https://github.com/jeffjirsa/cassandra/commit/79642ea4f56a33f249e807abdd562f89d20f6c36
Diff at
https://github.com/apache/cassandra/compare/trunk...jeffjirsa:cassandra-5791.diff
, I'll also attach here as cassandra-5791-20150319.diff
Passing:
{noformat}
[junit] ------------- ---------------- ---------------
[junit] Testsuite: org.apache.cassandra.db.VerifyTest
[junit] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
2.803 sec
[junit]
{noformat}
[~jbellis] and [~benedict] - if you want unit tests for DataIntegrityMetadata,
Jira it, assign me, and I'll write them. I'd have done it tonight but I can't
convince myself that they're not redundant with the (included) verifier unit
tests which will test the checksums anyway.
> A nodetool command to validate all sstables in a node
> -----------------------------------------------------
>
> Key: CASSANDRA-5791
> URL: https://issues.apache.org/jira/browse/CASSANDRA-5791
> Project: Cassandra
> Issue Type: New Feature
> Components: Core
> Reporter: sankalp kohli
> Assignee: Jeff Jirsa
> Priority: Minor
> Fix For: 3.0
>
> Attachments: cassandra-5791-20150319.diff,
> cassandra-5791-patch-3.diff, cassandra-5791.patch-2
>
>
> CUrrently there is no nodetool command to validate all sstables on disk. The
> only way to do this is to run a repair and see if it succeeds. But we cannot
> repair the system keyspace.
> Also we can run upgrade sstables but that re writes all the sstables.
> This command should check the hash of all sstables and return whether all
> data is readable all not. This should NOT care about consistency.
> The compressed sstables do not have hash so not sure how it will work there.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
